This repository was archived by the owner on Dec 6, 2025. It is now read-only.
Feature/adding pylsp #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the developer experience by adding VS Code configurations, updating linting/language‐server dependencies, and enforcing consistent import ordering.
- Added
.vscodedebug, task, and editor settings for testing, linting, and formatting. - Updated
pyproject.tomlwith Python LSP and Ruff configurations plus new dependencies. - Reordered imports in multiple modules to follow PEP 8 grouping.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/verity.py | Reordered standard‐lib imports for consistency |
| src/tests/test_config.py | Grouped imports in the preferred stdlib–third-party–local order |
| src/front/home.py | Consolidated and alphabetized Flask imports |
| src/data_handler.py | Swapped sqlite3 and logging to match alphabetical ordering |
| src/config.py | Adjusted blank lines to separate stdlib and third-party imports |
| pyproject.toml | Added python-lsp-ruff, python-lsp-server, and related configs |
| .vscode/tasks.json | Introduced tasks for running tests, lint checks, and pre-commit |
| .vscode/settings.json | Configured Pylance, Ruff formatting, import organization, and paths |
| .vscode/launch.json | Added launch configuration for debugging verity.py |
Comments suppressed due to low confidence (1)
.vscode/settings.json:13
- Two JSON keys are placed on the same line, making this invalid JSON. Split them onto separate lines and ensure proper comma placement.
"editor.formatOnSaveMode": "file", "python.analysis.extraPaths": [
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Jake-Pullen
reviewed
May 30, 2025
Owner
Jake-Pullen
left a comment
Jake-Pullen
left a comment
There was a problem hiding this comment.
I like and agree with these changes, could you please git ignore the .vscode directory though
Owner
I've done some digging and we can disregard the git ignore stuff for now and open up a conversation of how we want this to look on the future |
Jake-Pullen
previously approved these changes
May 30, 2025
added 2 commits
May 30, 2025 20:40
Jake-Pullen
previously approved these changes
May 30, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the development environment with VS Code configurations, adds Python LSP and Ruff support, and tidies import organization across the codebase.
- Introduce VS Code tasks, settings, and launch configs for testing, linting, debugging, and environment sync.
- Update
pyproject.tomlto includepython-lsp-ruffandpython-lsp-serverplus related tool settings. - Re-organize imports in multiple modules for consistent sorting and grouping.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/verity.py | Reordered and grouped standard‐library imports |
| src/tests/test_config.py | Organized os, third‐party, and local imports |
| src/front/home.py | Combined and alphabetized Flask imports |
| src/data_handler.py | Sorted stdlib imports |
| src/config.py | Separated stdlib and third‐party imports with a blank line |
| pyproject.toml | Added LSP and Ruff dependencies and tool configurations |
| .vscode/tasks.json | Defined tasks for running tests, linting, debugging, and syncing |
| .vscode/settings.json | Configured Pylance, pytest, and Ruff formatting on save |
| .vscode/launch.json | Added a debug configuration for verity.py |
Comments suppressed due to low confidence (2)
.vscode/tasks.json:66
- [nitpick] The task label has a trailing space which could cause confusion when referencing tasks. Remove the extra space at the end of "UV Sync ".
"label": "UV Sync ",
.vscode/settings.json:13
- This line contains two JSON properties on the same line, which makes the settings file invalid JSON. Split them into separate lines so each key/value pair is on its own line.
"editor.formatOnSaveMode": "file", "python.analysis.extraPaths": [
Jake-Pullen
approved these changes
May 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the development environment and minor codebase improvements. The primary focus is on configuring VS Code for debugging, linting, and testing, adding Ruff and Python LSP support, and improving import organization across multiple files.
Development Environment Enhancements:
.vscode/launch.json: Added a debug configuration for running theverity.pyscript with integrated terminal support and environment setup..vscode/settings.json: Configured VS Code to use the Pylance language server, enabledpytestfor testing, and integrated Ruff for linting and import organization..vscode/tasks.json: Added tasks for running tests, linting with Ruff, pre-commit checks, and syncing the environment usinguv.Dependency and Tooling Updates:
pyproject.toml: Added dependencies forpython-lsp-ruffandpython-lsp-server. Configured Ruff for linting, import organization, and defined line length and target Python version. [1] [2]Codebase Improvements:
src/config.py,src/data_handler.py,src/front/home.py,src/tests/test_config.py,src/verity.py) to improve readability and follow best practices. [1] [2] [3] [4] [5]